Fix panic in BasicAuthDecode #14046
Merged
Fix panic in BasicAuthDecode #14046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the string does not contain ":" that function would run into an `index out of range [1] with length 1` error. prevent that.
6543
reviewed
Dec 18, 2020
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Dec 18, 2020
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Dec 18, 2020
GiteaBot
added
lgtm/done
|
please send backport :) |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 18, 2020
* Fix panic in BasicAuthDecode If the string does not contain ":" that function would run into an `index out of range [1] with length 1` error. prevent that. * Update BasicAuthDecode() Co-authored-by: 6543 <[email protected]>
lunny
pushed a commit
that referenced
this pull request
Dec 18, 2020
* Fix panic in BasicAuthDecode If the string does not contain ":" that function would run into an `index out of range [1] with length 1` error. prevent that. * Update BasicAuthDecode() Co-authored-by: 6543 <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the decoded string does not contain ":" that function would run into an
index out of range [1] with length 1error. prevent that.