Skip to content

Fix api doc response code #14123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 24, 2020
Merged

Fix api doc response code #14123

merged 4 commits into from
Dec 24, 2020

Conversation

noerw
Copy link
Member

@noerw noerw commented Dec 23, 2020

fixes #14120

@noerw noerw added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 23, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 23, 2020
@noerw noerw changed the title [skip-ci] fix api doc response code [skip ci] fix api doc response code Dec 24, 2020
@zeripath
Copy link
Contributor

We can't merge if you skip ci.

@zeripath zeripath changed the title [skip ci] fix api doc response code Fix api doc response code Dec 24, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit bdeccc3 into go-gitea:master Dec 24, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! and removed type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 24, 2020
@6543
Copy link
Member

6543 commented Dec 24, 2020

@noerw such things are breaking!

normaly I added a TODO note vor api v2 on souch kind of things

@noerw
Copy link
Member Author

noerw commented Dec 24, 2020 •
edited
Loading

@6543 the docs were inconsistent with actual behaviour, so i'm not sure what is going to break here? 🤔

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Dec 24, 2020
@6543
Copy link
Member

6543 commented Dec 24, 2020

@noerw sorry you are right you just correct the swagger doc - dont know what I had in mind while looking at this pull ?!?

@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API document error: userCreateToken API success responses code should be 201.
6 participants
@noerw @zeripath @6543 @lunny @a1012112796 @GiteaBot