Skip to content

Fix admin monitoring margin #14134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Fix admin monitoring margin #14134

merged 3 commits into from
Dec 23, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 23, 2020

Before:
Screen Shot 2020-12-23 at 19 51 13

After:
Screen Shot 2020-12-23 at 19 50 24

Fomantic CSS:

.ui.table {
  margin: 1em 0;
}
.ui.table:first-child {
  margin-top: 0;
}

Because the table is not the first child of its parent, that margin removal did not work. Fix by moving other children after the table.

@silverwind silverwind added type/bug topic/ui Change the appearance of the Gitea UI labels Dec 23, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 23, 2020
@6543
Copy link
Member

6543 commented Dec 23, 2020

🚀

@6543 6543 merged commit 87a0396 into go-gitea:master Dec 23, 2020
@silverwind silverwind deleted the marginadmin branch December 23, 2020 20:51
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 23, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 23, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants