Skip to content

Use IsProd instead of testing if it's equal. #14336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2021
Merged

Use IsProd instead of testing if it's equal. #14336

merged 4 commits into from
Jan 14, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 14, 2021

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 14, 2021
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@edbc5c8). Click here to learn what that means.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14336   +/-   ##
=========================================
  Coverage          ?   41.87%           
=========================================
  Files             ?      744           
  Lines             ?    79639           
  Branches          ?        0           
=========================================
  Hits              ?    33346           
  Misses            ?    40807           
  Partials          ?     5486
Impacted Files Coverage Δ
cmd/serv.go 2.63% <0.00%> (ø)
models/models.go 57.00% <0.00%> (ø)
modules/httpcache/httpcache.go 0.00% <0.00%> (ø)
routers/routes/recovery.go 26.92% <20.00%> (ø)
modules/setting/setting.go 49.03% <100.00%> (ø)
routers/init.go 45.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edbc5c8...8dfb32a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2021
jolheiser
jolheiser reviewed Jan 14, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2021
jolheiser
jolheiser reviewed Jan 14, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2021
@lafriks
Copy link
Member

lafriks commented Jan 14, 2021

🚀

@lafriks lafriks merged commit 84b147c into go-gitea:master Jan 14, 2021
@lunny lunny deleted the lunny/is_prod branch January 15, 2021 01:29
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@jolheiser jolheiser jolheiser left review comments

@6543 6543 6543 approved these changes

@tomaswarynyca tomaswarynyca tomaswarynyca approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @codecov-io @lafriks @zeripath @6543 @tomaswarynyca @jolheiser @GiteaBot