Note that all template directories are relative to the CustomPath configuration, not a custom directory inside it
#14399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration, not a `custom` directory inside it. This is a minor clarification, which makes locating where the templates need to be much easier
Codecov Report
@@ Coverage Diff @@
## master #14399 +/- ##
=======================================
Coverage 41.84% 41.85%
=======================================
Files 744 744
Lines 79779 79779
=======================================
+ Hits 33387 33394 +7
- Misses 40874 40876 +2
+ Partials 5518 5509 -9
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Jan 19, 2021
|
I would prefere |
GiteaBot
added
lgtm/need 1
It's more obvious it's a variable and not a typo
6543
approved these changes
Jan 19, 2021
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor clarification, which makes locating where the templates need to be much easier.
It took me a while to realise that the templates directory had to be
/data/gitea/templatesrather than/data/gitea/custom/templates. Referring to the custom directory ascustomin the examples lead to this confusion, so I replaced it withCustomPath, which looks more like a variable, as defined at the top of the page. This could be replaced with$GITEA_CUSTOM, which is IMO clearer, but less accurate, as that variable isn't used often.