Skip to content

Use gitea.svg instead of logo.svg #14479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

kdumontnu
Copy link
Contributor

Small fix to use gitea.svg instead of logo.svg for public/img/svg/gitea-gitea.svg

Prevents user from breaking the gitea svg when they update assets/logo.svg

@codecov-io
Copy link

Codecov Report

Merging #14479 (c173286) into master (a598877) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14479      +/-   ##
==========================================
- Coverage   42.12%   42.11%   -0.02%     
==========================================
  Files         758      758              
  Lines       81080    81083       +3     
==========================================
- Hits        34155    34148       -7     
- Misses      41352    41359       +7     
- Partials     5573     5576       +3     
Impacted Files Coverage Δ
models/issue.go 57.24% <100.00%> (+0.10%) ⬆️
modules/indexer/stats/db.go 56.00% <0.00%> (-12.00%) ⬇️
modules/git/tree_nogogit.go 60.86% <0.00%> (-8.70%) ⬇️
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-4.26%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.52% <0.00%> (-2.21%) ⬇️
models/error.go 39.48% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 42.15% <0.00%> (ø)
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5845c87...c173286. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 27, 2021
@6543 6543 added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 27, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2021
@6543
Copy link
Member

6543 commented Jan 27, 2021

@kdumontnu can you "update branch" ?

@6543
Copy link
Member

6543 commented Jan 27, 2021

🚀

@6543 6543 merged commit 4c6e029 into go-gitea:master Jan 27, 2021
@kdumontnu kdumontnu deleted the kd/gitea_svg_not_logo branch February 16, 2021 22:50
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants