Skip to content

Fix switch language #14484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2021
Merged

Fix switch language #14484

merged 4 commits into from
Jan 27, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 27, 2021

Fix #14482

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 27, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 27, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #14484 (9d9ed87) into master (c10503a) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14484      +/-   ##
==========================================
- Coverage   42.11%   42.10%   -0.02%     
==========================================
  Files         758      758              
  Lines       81104    81103       -1     
==========================================
- Hits        34160    34146      -14     
- Misses      41367    41377      +10     
- Partials     5577     5580       +3     
Impacted Files Coverage Δ
modules/middlewares/locale.go 70.58% <25.00%> (-12.75%) ⬇️
modules/indexer/stats/db.go 56.00% <0.00%> (-12.00%) ⬇️
modules/middlewares/cookie.go 48.27% <0.00%> (-10.35%) ⬇️
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-6.39%) ⬇️
modules/git/batch_reader_nogogit.go 44.77% <0.00%> (-1.50%) ⬇️
services/pull/pull.go 42.15% <0.00%> (-0.50%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (ø)
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1080b27...9d9ed87. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2021
@lafriks lafriks merged commit 669ff8e into go-gitea:master Jan 27, 2021
@lunny lunny deleted the lunny/fix_switch_lang branch January 27, 2021 14:57
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: language cookie not set
5 participants