Skip to content

Add helper descriptions on new repo page #14591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2021

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Feb 7, 2021

Add helpers for:

  • repo description
  • .gitignore
  • license
  • README
  • default branch
  • signature trust model

Signed-off-by: Bagas Sanjaya [email protected]

Add helpers for:
  * repo description
  * .gitignore
  * license
  * README
  * default branch
  * signature trust model

Signed-off-by: Bagas Sanjaya <[email protected]>
@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Feb 7, 2021
@a1012112796
Copy link
Member

@bagasme would you please add some screenshot on pull description. Thanks.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2021
@bagasme
Copy link
Contributor Author

bagasme commented Feb 16, 2021

review ping

Copy link
Member

@noerw noerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! please merge current master

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2021
To match similar helper.

trust_model_helper_intro -> trust_model_helper

Signed-off-by: Bagas Sanjaya <[email protected]>
@bagasme bagasme force-pushed the new-repo-helper-desc branch from 342e351 to e71f482 Compare February 21, 2021 08:55
@codecov-io
Copy link

Codecov Report

Merging #14591 (e71f482) into master (487f2ee) will decrease coverage by 0.00%.
The diff coverage is 42.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14591      +/-   ##
==========================================
- Coverage   42.21%   42.21%   -0.01%     
==========================================
  Files         767      771       +4     
  Lines       81624    82078     +454     
==========================================
+ Hits        34458    34647     +189     
- Misses      41531    41783     +252     
- Partials     5635     5648      +13     
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 58.05% <0.00%> (-0.45%) ⬇️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
modules/migrations/github.go 77.77% <0.00%> (-1.99%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6068c1...e71f482. Read the comment docs.

@lunny lunny merged commit 1f13229 into go-gitea:master Feb 21, 2021
@lunny lunny added this to the 1.14.0 milestone Feb 21, 2021
@bagasme bagasme deleted the new-repo-helper-desc branch February 21, 2021 10:44
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants