Fix error 500 on organization dashboard page #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will send a PR to fix that. |
|
is this fixed the same as #149? |
|
It's not the same. |
|
This should be a bug of xorm. I will fix it and we should not change gitea's code. |
|
@lunny if you can change the behavior of |
|
Yes. I have. #150 changed like you said. |
|
Nice, you got my LGTM, just need one more to merge |
|
Yes. So you can close this PR. |
ethantkoenig
pushed a commit
to ethantkoenig/gitea
that referenced
this pull request
Feb 15, 2017
Changes from gitea:master
delvh
added
issue/not-a-bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pul request fix an error 500 on organization dashboard page. When an organization don't contains any repositories, the count SQL query return nothing.