Skip to content

Remove unused commit #14741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2021
Merged

Remove unused commit #14741

merged 5 commits into from
Feb 20, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 19, 2021

As title.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 19, 2021
@6543
Copy link
Member

6543 commented Feb 19, 2021

It schould be used

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2021
@lunny
Copy link
Member Author

lunny commented Feb 19, 2021

It schould be used

No. All transaction begin in the loop and commit end in the loop. This commit is out of the loop and no related begin invoked.

@6543

This comment has been minimized.

Sign in to view
@lunny
Copy link
Member Author

lunny commented Feb 19, 2021

For a single SQL, claim a transaction is unnecessary. And even if you want to do that, you need a Begin before Update.

@6543

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2021
@6543 6543 added this to the 1.14.0 milestone Feb 19, 2021
@a1012112796
a small nit
f31f781 
Signed-off-by: a1012112796 <[email protected]>
a1012112796
a1012112796 approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit: lunny#13

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2021
@6543 6543 merged commit f3e64f6 into go-gitea:master Feb 20, 2021
@lunny lunny deleted the lunny/fix_v166 branch February 21, 2021 09:25
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @6543 @a1012112796 @GiteaBot