Update golangci-lint v1.35.2 -> v1.37.0 #14747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
topic/build
jolheiser
approved these changes
Feb 19, 2021
GiteaBot
added
the
lgtm/need 1
|
@jolheiser see discord #maintainer chat ... - we have more and more issues in CI with golangci-lint and this looks like it fix it |
a1012112796
approved these changes
Feb 19, 2021
GiteaBot
added
lgtm/done
|
I'd like pre install it in test-env also. |
a1012112796
reviewed
Feb 19, 2021
| @@ -708,7 +708,7 @@ pr\#%: clean-all | |||
| golangci-lint: | |||
| @hash golangci-lint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ | |||
There was a problem hiding this comment.
wonder if we need request min version..
|
@a1012112796 think this is worth it's own pull ... merge this fast so CI passes more often again ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title