Skip to content

Make internal SSH server host key path configurable #14918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 8, 2021
Merged

Make internal SSH server host key path configurable #14918

merged 12 commits into from
Mar 8, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 7, 2021 •
edited
Loading

Make the internal SSH host key path configurable and add to the documentation. Allow multiple host keys.

Also increase default key size from 2048 to 4096 bits.

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Mar 7, 2021
@zeripath zeripath added this to the 1.14.0 milestone Mar 7, 2021
@zeripath
Copy link
Contributor Author

zeripath commented Mar 7, 2021

I think this should be 1.14 as it is a security feature.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 7, 2021
zeripath added 2 commits March 7, 2021 14:54
@zeripath
make it possible to have multiple keys
9eb2d0b 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
oops
519216d 
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
lafriks reviewed Mar 7, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 7, 2021
lafriks
lafriks reviewed Mar 7, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 7, 2021
@6543
Copy link
Member

6543 commented Mar 8, 2021

🚀

@6543 6543 merged commit c03f530 into go-gitea:master Mar 8, 2021
@zeripath zeripath deleted the ecdsa-other-keys branch March 8, 2021 06:57
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @6543 @lafriks @GiteaBot