Do not show full lfs file on error in git_test.go:rawTest() #14980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a problem uploading to LFS it is possible for the raw endpoint to return a very large file when a pointer file is expected This will then cause the drone logs to fill up unnecessarily with the contents of the very large file. If the file returned from raw is of the incorrect size we should therefore not test it see if it contains the pointer file and just declare that it is incorrect. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/testing
skip-changelog
Signed-off-by: Andrew Thornton <[email protected]>
noerw
reviewed
Mar 13, 2021
| @@ -216,7 +216,10 @@ func rawTest(t *testing.T, ctx *APITestContext, little, big, littleLFS, bigLFS s | |||
| req = NewRequest(t, "GET", path.Join("/", username, reponame, "/raw/branch/master/", littleLFS)) | |||
| resp = session.MakeRequest(t, req, http.StatusOK) | |||
| assert.NotEqual(t, littleSize, resp.Body.Len()) | |||
| assert.Contains(t, resp.Body.String(), models.LFSMetaFileIdentifier) | |||
| assert.LessOrEqual(t, resp.Body.Len(), 1024) | |||
| if resp.Body.Len() != littleSize && resp.Body.Len() <= 1024 { | |||
There was a problem hiding this comment.
This condition is already asserted above, right?
Can't we check for the exact expected length?
Are there tests for small and large files?
There was a problem hiding this comment.
The reason for the changes being the way they are is because of the contains below this line.
If the resp.Body does not contain the expected value it will be emitted whole into the test response.
This is bad and completely unreadable - we therefore need to skip doing that test in that case.
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Mar 13, 2021
GiteaBot
added
lgtm/need 1
noerw
approved these changes
Mar 13, 2021
GiteaBot
added
lgtm/done
|
make lgtm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a problem uploading to LFS it is possible for the raw
endpoint to return a very large file when a pointer file is expected
This will then cause the drone logs to fill up unnecessarily with
the contents of the very large file.
If the file returned from raw is of the incorrect size we should
therefore not test it see if it contains the pointer file
and just declare that it is incorrect.
Signed-off-by: Andrew Thornton [email protected]