Skip to content

Git graph: fix UI elements getting underline like links #15038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

CL-Jeremy
Copy link
Contributor

UI elements (labels, buttons) have hover highlighting and do not require underlining (checked that this code exist since introduction of this feature).

For whatever reason, signed commit labels already do not respond to this rule before this PR (they do after my rework, so this fixes that), so this goes further to exclude just everything of class ui (I don't think there will be nested links).

@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 19, 2021
@6543 6543 added this to the 1.14.0 milestone Mar 19, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 19, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 19, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2021
@6543 6543 merged commit 54d7b0f into go-gitea:master Mar 19, 2021
@CL-Jeremy CL-Jeremy deleted the fix-ui-elements-underlining branch March 19, 2021 02:22
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants