Fix bug when upload on web

modules/repofiles/upload.go

@@ -125,15 +125,13 @@ func UploadRepoFiles(repo *models.Repository, doer *models.User, opts *UploadRep
 				return err
 			}
 			infos[i] = uploadInfo
-
 		} else if objectHash, err = t.HashObject(file); err != nil {
 			return err
 		}
 
 		// Add the object to the index
 		if err := t.AddObjectToIndex("100644", objectHash, path.Join(opts.TreePath, uploadInfo.upload.Name)); err != nil {
 			return err
-
 		}
 	}
 
@@ -183,14 +181,15 @@ func UploadRepoFiles(repo *models.Repository, doer *models.User, opts *UploadRep
 			if err != nil {
 				return cleanUpAfterFailure(&infos, t, err)
 			}
-			defer file.Close()
 			// FIXME: Put regenerates the hash and copies the file over.
 			// I guess this strictly ensures the soundness of the store but this is inefficient.
 			if err := contentStore.Put(uploadInfo.lfsMetaObject, file); err != nil {
+				file.Close()
 				// OK Now we need to cleanup
 				// Can't clean up the store, once uploaded there they're there.
 				return cleanUpAfterFailure(&infos, t, err)
 			}
+			file.Close()
 		}
 	}