Skip to content

Handle unauthorized user events gracefully #15071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2021
Merged

Handle unauthorized user events gracefully #15071

merged 2 commits into from
Mar 20, 2021
+12 −1

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 20, 2021

Otherwise it would return user login page for ajax requests and log errors in console for unauthorized users

@lafriks lafriks added this to the 1.15.0 milestone Mar 20, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2021
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@78e8f62). Click here to learn what that means.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #15071   +/-   ##
=========================================
  Coverage          ?   42.10%           
=========================================
  Files             ?      777           
  Lines             ?    83394           
  Branches          ?        0           
=========================================
  Hits              ?    35116           
  Misses            ?    42572           
  Partials          ?     5706
Impacted Files Coverage Δ
routers/events/events.go 0.00% <0.00%> (ø)
routers/routes/web.go 85.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e8f62...7475b61. Read the comment docs.

@6543 6543 merged commit 2f0eb9f into go-gitea:master Mar 20, 2021
@6543
Copy link
Member

6543 commented Mar 20, 2021

@lafriks please backport 🚀

@lafriks lafriks deleted the fix/unauthorized_user_events branch March 20, 2021 20:44
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Mar 20, 2021
@lafriks
Handle unauthorized user events gracefully (go-gitea#15071)
150d6b4
zeripath pushed a commit that referenced this pull request Mar 21, 2021
@lafriks
Handle unauthorized user events gracefully (#15071) (#15074)
ac2ae66
@zeripath zeripath mentioned this pull request Mar 21, 2021
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 21, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @6543 @zeripath @GiteaBot