Fix lock modal content rendering outside modal #15095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .content was not a child to .modal so was rendering outside. This is a recent regression but I'm not certain when it was introduced.
|
There seems to be another tag imbalance in the file, checking... |
GiteaBot
added
the
lgtm/need 2
|
Ok should be resolved. The cause of the whole issue was the extra |
|
@silverwind thanks :) - will test |
6543
approved these changes
Mar 21, 2021
GiteaBot
added
lgtm/need 1
noerw
approved these changes
Mar 21, 2021
GiteaBot
added
lgtm/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 21, 2021
* Fix lock modal content rendering outside modal The .content was not a child to .modal so was rendering outside. This is a recent regression but I'm not certain when it was introduced. * remove extraneous closing div
6543
pushed a commit
that referenced
this pull request
Mar 22, 2021
* Fix lock modal content rendering outside modal The .content was not a child to .modal so was rendering outside. This is a recent regression but I'm not certain when it was introduced. * remove extraneous closing div Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by dc08195. A extraneous
</div>caused.contentto not be a child to.modalany more so it was rendering outside the actual modal.Before
After