Skip to content

Fixed #15020 #15098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2021
Merged

Fixed #15020 #15098

merged 1 commit into from
Mar 21, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Mar 21, 2021

Addition for #15020.

assert.Equals itself prints both values so the previous fix was only half the work.
grafik

@6543 6543 added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 21, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 21, 2021
@6543 6543 added this to the 1.15.0 milestone Mar 21, 2021
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Mar 21, 2021

Alternative implementation could be

if diffStr != actual {
  assert.Fail(t, "Unexpected change in the diff string: expected: %s but was actually: %s", diffStr[:expectedMaxLen], actual[:actualMaxLen])
}

if the Should be true message is unwanted.

@KN4CK3R KN4CK3R changed the title Fixed previous fix. Fixed #15020 Mar 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2021
@zeripath zeripath merged commit 32833a9 into go-gitea:master Mar 21, 2021
@KN4CK3R KN4CK3R deleted the fix-extraneous-logging branch March 21, 2021 19:56
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants