Skip to content

Fix the v176 migration (#15110) #15111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix the v176 migration (#15110) #15111

merged 1 commit into from
Mar 22, 2021

Conversation

zeripath
Copy link
Contributor

Backport #15110

There is a serious issue with the v176 migration where there is a mistaken missing
label_id selection.

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Fix the v176 migration (go-gitea#15110)
bc4bbc4 
Backport go-gitea#15110

There is a serious issue with the v176 migration where there is a mistaken missing
label_id selection.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Mar 22, 2021
@zeripath zeripath added this to the 1.14.0 milestone Mar 22, 2021
6543
6543 reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uff - sorry for overlooking in previous review!! - again

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2021
@6543
Copy link
Member

6543 commented Mar 22, 2021

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf thanks for digging into this !!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2021
@zeripath zeripath mentioned this pull request Mar 22, 2021
Merged
@techknowlogick techknowlogick merged commit 14011d7 into go-gitea:release/v1.14 Mar 22, 2021
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf thanks for digging into this !!

in fact kudos go to @zeripath here 🚀
I only noticed something was off..

@zeripath zeripath deleted the backport-15110 branch March 23, 2021 18:42
@6543 6543 added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 9, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @6543 @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @noerw @techknowlogick @GiteaBot