Fix wrong user returned in API (#15139) #15151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
6543
added
modifies/api
6543
approved these changes
Mar 25, 2021
GiteaBot
added
the
lgtm/need 1
|
@6543 I think we should re-work the fix, see #15139 (comment) |
6543
requested changes
Mar 25, 2021
|
@6543: How would you like that I proceed? |
zeripath
approved these changes
Mar 25, 2021
GiteaBot
added
lgtm/done
6543
reviewed
Mar 26, 2021
6543
approved these changes
Mar 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15139
The API call: GET /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
returns always the reviewer, but should return the poster.
Co-authored-by: 6543 [email protected]
Co-authored-by: zeripath [email protected]