Skip to content

Diff box fixes #15214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Diff box fixes #15214

merged 5 commits into from
Mar 31, 2021

Conversation

silverwind
Copy link
Member

  • Fix misaligned "Show Outdated" buttons via flexbox
  • Add hover effect to "Show Outdated" buttons
  • Remove overreaching margin from selector .diff-file-box and handle cases individually.

Fixes: #15097

Screen Shot 2021-03-30 at 23 12 55

image

Screen Shot 2021-03-30 at 22 36 25

@silverwind silverwind added backport/v1.14 type/bug topic/ui Change the appearance of the Gitea UI labels Mar 30, 2021
@silverwind silverwind added this to the 1.14.0 milestone Mar 30, 2021
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: go-gitea#15097
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2021
@a1012112796 a1012112796 modified the milestones: 1.14.0, 1.15.0 Mar 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit aee5ef0 into go-gitea:master Mar 31, 2021
@techknowlogick
Copy link
Member

@silverwind please send backport :)

silverwind added a commit to silverwind/gitea that referenced this pull request Mar 31, 2021
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: go-gitea#15097

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@silverwind silverwind deleted the fix-collapse branch March 31, 2021 22:50
@6543 6543 added the backport/done All backports for this PR have been created label Mar 31, 2021
lafriks pushed a commit that referenced this pull request Apr 1, 2021
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: #15097

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

borked button alignment
8 participants