Skip to content

Update docs for bad ini syntax in noreply #15226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

kdumontnu
Copy link
Contributor

@kdumontnu kdumontnu commented Mar 31, 2021

Small nit, but the example used in app.example.ini for NO_REPLY_ADDRESS will cause gitea to error with:

models/avatar.go:72:LibravatarURL() [E] LibravatarService.FromEmail(email=user@noreply.%(domain)s): error mail: expected single address, got "s"

Ini only supports recursive values in For all value of keys, there is a special syntax %(<name>)s, where <name> is the key name in same section or default section

Note: I've added an upstream feature request to allow ini to reference values from other sections.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2021
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Mar 31, 2021
@techknowlogick techknowlogick merged commit 8d9f191 into go-gitea:master Mar 31, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants