Skip to content

Use true for RACE_ENABLED #15261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2021
Merged

Use true for RACE_ENABLED #15261

merged 2 commits into from
Jun 2, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 3, 2021

as title

@6543 6543 added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 3, 2021
@zeripath

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2021
@6543 6543 force-pushed the fix-race-on-tests branch from e002094 to 9644350 Compare April 4, 2021 04:11
@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/wip This PR is not ready for review and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 4, 2021
@6543

This comment has been minimized.

Sign in to view
@zeripath

This comment has been minimized.

Sign in to view
@zeripath

This comment has been minimized.

Sign in to view
@6543 6543 mentioned this pull request Apr 17, 2021
Merged
6 tasks
@6543 6543 force-pushed the fix-race-on-tests branch from e1decbb to 028baa0 Compare June 1, 2021 19:45
@6543 6543 changed the title Fix archiver race on tests Use "true" for RACE_ENABLED Jun 1, 2021
@6543
Copy link
Member Author

6543 commented Jun 1, 2021

since #14723 will do a way better job, lets just take the refactor of Makefile and merge it in ...

cc @lunny

PS: I'll ajust #1441 after it got merged ...

@6543 6543 removed the pr/wip This PR is not ready for review label Jun 1, 2021
@6543 6543 force-pushed the fix-race-on-tests branch from ec581c9 to 3ef6e7b Compare June 2, 2021 00:27
@6543 6543 changed the title Use "true" for RACE_ENABLED Use true for RACE_ENABLED Jun 2, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 2, 2021
@6543 6543 requested a review from zeripath June 2, 2021 09:43
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15261 (96cdac4) into main (9fdda90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15261   +/-   ##
=======================================
  Coverage   44.06%   44.06%           
=======================================
  Files         682      682           
  Lines       82457    82457           
=======================================
  Hits        36338    36338           
+ Misses      40202    40201    -1     
- Partials     5917     5918    +1
Impacted Files Coverage Δ
modules/queue/unique_queue_disk_channel.go 47.26% <0.00%> (-1.37%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/queue/workerpool.go 55.34% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdda90...96cdac4. Read the comment docs.

@6543 6543 merged commit c1ff59c into go-gitea:main Jun 2, 2021
@6543 6543 deleted the fix-race-on-tests branch June 2, 2021 15:34
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @AbdulrhmnGhanem
use "true" for RACE_ENABLED (go-gitea#15261)
d39666e
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@zeripath zeripath Awaiting requested review from zeripath

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @zeripath @codecov-commenter @lunny @KN4CK3R @GiteaBot