Fix delete nonexist oauth application 500 and prevent deadlock #15384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Apr 10, 2021
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Apr 10, 2021
GiteaBot
added
lgtm/done
|
Somehow this appears to be killing CI. |
|
I guess MakeRequest could not be invoke twice because req has been consumed. |
lunny
force-pushed
the
lunny/delete_oauth2
branch
from
f063aa5 to
44b893f
Compare
6543
reviewed
Apr 10, 2021
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
6543
approved these changes
Apr 10, 2021
zeripath
approved these changes
Apr 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #15384 +/- ##
==========================================
+ Coverage 42.21% 43.63% +1.41%
==========================================
Files 767 677 -90
Lines 81624 81338 -286
==========================================
+ Hits 34458 35488 +1030
+ Misses 41531 40058 -1473
- Partials 5635 5792 +157
Continue to review full report at Codecov.
|
|
@lunny please send backports :) |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 11, 2021
…tea#15384) * Fix delete nonexist oauth application 500 * Fix test * Close the session Signed-off-by: Andrew Thornton <[email protected]> * Update integrations/api_oauth2_apps_test.go * Fix more missed sess.Close * Remove unnecessary blank line Co-authored-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 11, 2021
…tea#15384) * Fix delete nonexist oauth application 500 * Fix test * Close the session Signed-off-by: Andrew Thornton <[email protected]> * Update integrations/api_oauth2_apps_test.go * Fix more missed sess.Close * Remove unnecessary blank line Co-authored-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
6543
added a commit
that referenced
this pull request
Apr 11, 2021
… (#15397) * Fix delete nonexist oauth application 500 * Fix test * Close the session * Fix more missed sess.Close * Remove unnecessary blank line Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
6543
added a commit
that referenced
this pull request
Apr 11, 2021
… (#15396) * Fix delete nonexist oauth application 500 * Fix test * Close the session * Fix more missed sess.Close * Remove unnecessary blank line Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 404 when asked to delete OAuth2 Application and ensure that the session is closed too.
Fix #15356