Improve signing documentation #15496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Apr 15, 2021
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Apr 15, 2021
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I configured signing on my installation yesterday. I used the default signing options and couldn't get gitea to sign a commit from the webeditor. So I read the signing documentation and my first thought was that multiple options are linked with an OR-Operation (if one returns true the commit (or whatever) will be signed).
Therefor I suspected a bad configuration and spent some time trying to find the error.
After some hours I looked at repo_sign.go and noticed that the options are not linked with OR but with AND instead.
I've added a sentence to each option on documentation page to clarify this behaviour for other users in the future.