Fix NPE on view commit with notes #15561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#15558 Signed-off-by: Andrew Thornton <[email protected]>
|
Hopefully @eveslage will be able to confirm that this does indeed fix the issue. |
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #15561 +/- ##
=======================================
Coverage 43.80% 43.81%
=======================================
Files 678 678
Lines 81730 81734 +4
=======================================
+ Hits 35803 35809 +6
+ Misses 40087 40086 -1
+ Partials 5840 5839 -1
Continue to review full report at Codecov.
|
lunny
approved these changes
Apr 21, 2021
GiteaBot
added
lgtm/need 1
6543
approved these changes
Apr 21, 2021
GiteaBot
added
lgtm/done
|
make lgtm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 21, 2021
Backport go-gitea#15561 Fix go-gitea#15558 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Apr 21, 2021
Backport #15561 Fix #15558 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mistake with the native git variant of GetNote when the note is referring to a non-root path.
This PR simply splits the path and passes the basedir into GetLastCommitPaths separate from the root path.
Fix #15558
Signed-off-by: Andrew Thornton [email protected]