-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix misaligned button in settings #15656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misaligned button in settings #15656
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15656 +/- ##
==========================================
+ Coverage 43.82% 43.92% +0.09%
==========================================
Files 678 678
Lines 81742 81743 +1
==========================================
+ Hits 35826 35908 +82
+ Misses 40073 39989 -84
- Partials 5843 5846 +3
Continue to review full report at Codecov.
|
I don't see any misalignment in before, however |
Not the icon is misaligned in the button but the button in the header. |
@bagasme The icons are too large for the button, so they stretch it out vertically. "Alignment" is maybe the wrong word here. What I'm referring to is the position of the button inside it's surrounding component. |
It misaligns because |
🚀 |
I noticed that the buttons in the LFS tab of the settings is slightly misaligned when compared to the rest of the tabs. This was due to icons that were not scaled properly.
Every other tab does not display icons, so I figured they probably shouldn't be there anyway to keep the UI consistent.
Before
After