Skip to content

Fix misaligned button in settings #15656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

garritfra
Copy link
Contributor

I noticed that the buttons in the LFS tab of the settings is slightly misaligned when compared to the rest of the tabs. This was due to icons that were not scaled properly.

Every other tab does not display icons, so I figured they probably shouldn't be there anyway to keep the UI consistent.

Before

image

After

image

@codecov-commenter
Copy link

Codecov Report

Merging #15656 (0f64c90) into master (2c57352) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15656      +/-   ##
==========================================
+ Coverage   43.82%   43.92%   +0.09%     
==========================================
  Files         678      678              
  Lines       81742    81743       +1     
==========================================
+ Hits        35826    35908      +82     
+ Misses      40073    39989      -84     
- Partials     5843     5846       +3     
Impacted Files Coverage Δ
modules/git/repo_commit.go 42.56% <0.00%> (-0.83%) ⬇️
routers/repo/view.go 41.24% <0.00%> (-0.09%) ⬇️
models/error.go 39.84% <0.00%> (+0.31%) ⬆️
services/pull/pull.go 43.47% <0.00%> (+0.45%) ⬆️
models/notification.go 66.07% <0.00%> (+0.88%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
modules/notification/notification.go 87.60% <0.00%> (+2.47%) ⬆️
modules/notification/base/null.go 78.94% <0.00%> (+2.63%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c57352...0f64c90. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2021
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Apr 29, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2021
@bagasme
Copy link
Contributor

bagasme commented Apr 29, 2021

I noticed that the buttons in the LFS tab of the settings is slightly misaligned when compared to the rest of the tabs. This was due to icons that were not scaled properly.

Every other tab does not display icons, so I figured they probably shouldn't be there anyway to keep the UI consistent.

Before

image

After

image

I don't see any misalignment in before, however

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 29, 2021

I don't see any misalignment in before, however

Not the icon is misaligned in the button but the button in the header.

@garritfra
Copy link
Contributor Author

@bagasme The icons are too large for the button, so they stretch it out vertically. "Alignment" is maybe the wrong word here. What I'm referring to is the position of the button inside it's surrounding component.

@silverwind
Copy link
Member

silverwind commented Apr 29, 2021

It misaligns because ui right absolutely positions the button's parent, preventing the header from being able to grow vertically. A better fix ought to be to remove this absolute positioning but I guess that would be a more involved change as it affects many places.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit f67e360 into go-gitea:master Apr 29, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants