Skip to content

Make let target "clean-all" remove node_modules folder too #15780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2021
Merged

Make let target "clean-all" remove node_modules folder too #15780

merged 4 commits into from
May 8, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented May 7, 2021

as title

@6543 6543 added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 7, 2021
@6543 6543 added this to the 1.15.0 milestone May 7, 2021
@6543 6543 requested a review from silverwind May 7, 2021 19:40
silverwind
silverwind reviewed May 7, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 7, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15780 (c5399fa) into main (9557b86) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15780      +/-   ##
==========================================
+ Coverage   43.96%   43.98%   +0.02%     
==========================================
  Files         678      678              
  Lines       81999    81999              
==========================================
+ Hits        36049    36066      +17     
+ Misses      40076    40062      -14     
+ Partials     5874     5871       -3
Impacted Files Coverage Δ
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
services/pull/pull.go 43.83% <0.00%> (+0.45%) ⬆️
models/gpg_key.go 54.07% <0.00%> (+0.56%) ⬆️
modules/queue/workerpool.go 52.74% <0.00%> (+1.09%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
services/pull/check.go 28.76% <0.00%> (+2.73%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9557b86...c5399fa. Read the comment docs.

a1012112796
a1012112796 reviewed May 8, 2021
View reviewed changes
Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2021
@6543 6543 merged commit 272bbb2 into go-gitea:main May 8, 2021
@6543 6543 deleted the make_clean-all_rm-node-modules branch May 8, 2021 09:57
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @AbdulrhmnGhanem
Make let target "clean-all" remove node_modules folder too (go-gitea#…
12cfb1d 
…15780)

* Make let target "clean-all" remove node_modules folder too
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-commenter @silverwind @a1012112796 @GiteaBot