Skip to content

remove unused truncate. #15838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

palytoxin
Copy link
Contributor

Separated from the previous pr ( #15828 )

Because the three columns has been form validated before it is saved, truncating it here will cause a truncate utf8 string bug

@6543 6543 requested a review from zeripath May 12, 2021 01:11
@palytoxin
Copy link
Contributor Author

But I think this is just a little repetitive, in fact, there is no problem not to make changes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2021
@a1012112796 a1012112796 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 12, 2021
@stale
Copy link

stale bot commented Jul 13, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 13, 2021
@wxiaoguang
Copy link
Contributor

I think we had better keep the code there.

The update may come from non-form request.

I will close this PR, feel free to feedback.

@wxiaoguang wxiaoguang closed this Nov 19, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants