Fix LFS commit finder not working #15856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
May 13, 2021
GiteaBot
added
the
lgtm/need 1
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
approved these changes
May 14, 2021
GiteaBot
added
lgtm/done
|
So the bug is really that the temporary buf was being saved repeatedly in the trees instead of being copied each time. |
|
@KN4CK3R please set a meaningfull title for this pull request. |
|
please send backport |
KN4CK3R
added a commit
to KN4CK3R/gitea
that referenced
this pull request
May 14, 2021
* Create a copy of the sha bytes. Co-authored-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
May 14, 2021
* Create a copy of the sha bytes. Co-authored-by: Andrew Thornton <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
* Create a copy of the sha bytes. Co-authored-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #15850
gitea/modules/git/pipeline/lfs_nogogit.go
Line 133 in 0ada74e
Here a
[40]bytewas compared with a[20]bytewhich always fails.The in place conversion in
To40ByteSHAmessed up thetreesslice because it got expanded multiple times.