Skip to content

Fix bound address/port for caddy's certmagic library #15859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2021
Merged

Fix bound address/port for caddy's certmagic library #15859

merged 3 commits into from
May 14, 2021

Conversation

bminer
Copy link
Contributor

@bminer bminer commented May 13, 2021

My apologies for the confusion. This PR fixes a bug introduced in #15848 and (I believe) solves the underlying issue this time around.

@techknowlogick
Copy link
Member

In fact this might be my bad, I suspect the ManageSync may be the culprit. I wonder if LE would work without that call.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15859 (a0250f3) into main (9545c34) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15859   +/-   ##
=======================================
  Coverage   44.00%   44.01%           
=======================================
  Files         681      681           
  Lines       82243    82247    +4     
=======================================
+ Hits        36194    36202    +8     
+ Misses      40140    40139    -1     
+ Partials     5909     5906    -3
Impacted Files Coverage Δ
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 43.83% <0.00%> (+0.45%) ⬆️
models/gpg_key.go 54.07% <0.00%> (+0.56%) ⬆️
modules/queue/workerpool.go 52.74% <0.00%> (+1.09%) ⬆️
modules/git/command.go 89.42% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9545c34...a0250f3. Read the comment docs.

@bminer
Copy link
Contributor Author

bminer commented May 13, 2021 •
edited
Loading

In fact this might be my bad, I suspect the ManageSync may be the culprit. I wonder if LE would work without that call.

That is an excellent question. I suspect that ManageSync is not necessary based on the example shown here. Note the //// OR //// comment in the source.

EDIT: Actually just ignore this comment because I don't know enough about certmagic to make any assertions. ;-)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2021
@zeripath
Copy link
Contributor

make LGTM work

@zeripath zeripath changed the title Fix bound address/port for caddy's certmagic library (see #15848) Fix bound address/port for caddy's certmagic library May 14, 2021
@zeripath zeripath merged commit e2f39c2 into go-gitea:main May 14, 2021
@zeripath
Copy link
Contributor

Please send backport

zeripath pushed a commit to zeripath/gitea that referenced this pull request May 14, 2021
@bminer @zeripath
Fix bound address/port for caddy's certmagic library (see go-gitea#15848
4d7cd8f 
) (go-gitea#15859)
@zeripath zeripath mentioned this pull request May 14, 2021
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label May 14, 2021
zeripath added a commit that referenced this pull request May 15, 2021
@zeripath @bminer @6543
Fix bound address/port for caddy's certmagic library (see #15848) (#1…
c21167e 
…5859) (#15878)

Co-authored-by: Blake Miner <[email protected]>
Co-authored-by: 6543 <[email protected]>
@bminer bminer mentioned this pull request Jun 17, 2021
Merged
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@bminer @AbdulrhmnGhanem
Fix bound address/port for caddy's certmagic library (see go-gitea#15848
a3b3079 
) (go-gitea#15859)
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bminer @techknowlogick @codecov-commenter @zeripath @lafriks @GiteaBot