Only write config in environment-to-ini if there are changes #15861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only write the new config in environment-to-ini if there are changes or the destination is not the same as the customconf. Fix go-gitea#15719 Fix go-gitea#15857 Signed-off-by: Andrew Thornton <[email protected]>
kdumontnu
approved these changes
May 13, 2021
GiteaBot
added
the
lgtm/need 1
noerw
approved these changes
May 13, 2021
GiteaBot
added
lgtm/done
6543
reviewed
May 13, 2021
|
🚀 |
zeripath
deleted the
fix-15857-15719-environment-to-ini-write-only-changes
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 14, 2021
…a#15861) Backport go-gitea#15861 * Only write config in environment-to-ini if there are changes Only write the new config in environment-to-ini if there are changes or the destination is not the same as the customconf. Fix go-gitea#15719 Fix go-gitea#15857 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
zeripath
added a commit
that referenced
this pull request
May 15, 2021
…#15868) Backport #15861 * Only write config in environment-to-ini if there are changes Only write the new config in environment-to-ini if there are changes or the destination is not the same as the customconf. Fix #15719 Fix #15857 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: 6543 <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
…a#15861) * Only write config in environment-to-ini if there are changes Only write the new config in environment-to-ini if there are changes or the destination is not the same as the customconf. Fix go-gitea#15719 Fix go-gitea#15857 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
delvh
added
topic/distribution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only write the new config in environment-to-ini if there are changes or the
destination is not the same as the customconf.
Fix #15719
Fix #15857
Signed-off-by: Andrew Thornton [email protected]