Fix blame row height alignment

[noerw]

fixes #15858 (check there for a screenshot)

I'm not a CSS guru, so my approach may be suboptimal:
We ensure all rows have at least 20px height, and .bottom-line rows get 21px, to reproduce in .lines-commit what was already configured in for the code view.

I tested in current FF and chromium, would be nice if someone could test on Safari as well.

[silverwind]

I think this is the third time now that this alignment broke. Blame should really be refactored to be line-based and not two columns side-by-side, but I guess we can workaround for now by manually aligning again.

[silverwind]

Tested, working, except Safari which needs one additional fix to prevent line wrapping breaking the alignment:

diff --git a/web_src/less/_base.less b/web_src/less/_base.less
index e44e2ab84..c3a7f6ca2 100644
--- a/web_src/less/_base.less
+++ b/web_src/less/_base.less
@@ -1503,8 +1503,9 @@ a.ui.label:hover {

 .blame .code-inner {
   white-space: pre;
   word-break: normal;
+  word-wrap: normal; /* not using overflow-wrap because safari does not treat is an an alias */
 }

 .lines-commit {
   vertical-align: top;

Normally overflow-wrap should be an alias to the deprecated word-wrap but I could only get it to work using word-wrap.

[codecov-commenter]

Codecov Report

Merging #15863 (ba9afda) into main (1a56599) will decrease coverage by 0.00%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main   #15863      +/-   ##
==========================================
- Coverage   44.00%   44.00%   -0.01%     
==========================================
  Files         681      681              
  Lines       82257    82270      +13     
==========================================
+ Hits        36199    36201       +2     
- Misses      40150    40161      +11     
  Partials     5908     5908              

Impacted Files	Coverage Δ
cmd/web_letsencrypt.go	0.00% <0.00%> (ø)
modules/git/pipeline/lfs_nogogit.go	0.00% <0.00%> (ø)
modules/migrations/gitea_uploader.go	7.47% <0.00%> (-0.02%)	⬇️
routers/admin/repos.go	0.00% <0.00%> (ø)
routers/api/v1/repo/repo.go	57.71% <0.00%> (-0.28%)	⬇️
modules/git/batch_reader.go	53.75% <100.00%> (ø)
modules/git/commit_info_nogogit.go	68.09% <100.00%> (ø)
routers/repo/setting.go	13.61% <100.00%> (+0.25%)	⬆️
modules/process/manager.go	72.83% <0.00%> (-2.47%)	⬇️
modules/queue/workerpool.go	51.64% <0.00%> (-1.10%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3febeb...ba9afda. Read the comment docs.

[zeripath]

I think we need a backport of this to 1.14 too.

[silverwind]

Yeah looks like it.