Skip to content

small refactor for retry downloader #16137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2021

Conversation

a1012112796
Copy link
Member

add a new function to do retry logic.

@a1012112796 a1012112796 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 12, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #16137 (03597ca) into main (0bf8d34) will increase coverage by 0.23%.
The diff coverage is 48.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16137      +/-   ##
==========================================
+ Coverage   44.02%   44.25%   +0.23%     
==========================================
  Files         681      694      +13     
  Lines       82336    82299      -37     
==========================================
+ Hits        36245    36422     +177     
+ Misses      40185    39991     -194     
+ Partials     5906     5886      -20     
Impacted Files Coverage Δ
cmd/serv.go 2.58% <0.00%> (-0.04%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
models/avatar.go 32.30% <ø> (ø)
models/consistency.go 39.57% <0.00%> (-1.01%) ⬇️
models/error.go 39.53% <0.00%> (-0.32%) ⬇️
models/repo.go 53.14% <0.00%> (-1.11%) ⬇️
modules/auth/ldap/ldap.go 46.81% <ø> (ø)
modules/avatar/avatar.go 47.72% <ø> (ø)
modules/base/tool.go 93.47% <ø> (-0.79%) ⬇️
modules/git/commit.go 60.16% <ø> (+3.69%) ⬆️
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2f9b3...03597ca. Read the comment docs.

@6543 6543 added this to the 1.15.0 milestone Jun 13, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2021
@6543 6543 merged commit a005265 into go-gitea:main Jun 13, 2021
@a1012112796 a1012112796 deleted the refrac-retry-download branch June 14, 2021 00:02
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants