cleanup code to init issueFullPattern in modules/markup
#16417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/refactoring
This was referenced Jul 13, 2021
6543
changed the title
issueFullPattern in modules/markup
KN4CK3R
approved these changes
Jul 13, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
reviewed
Jul 13, 2021
| @@ -72,7 +72,7 @@ var ( | |||
| const keywordClass = "issue-keyword" | |||
|
|
|||
| // regexp for full links to issues/pulls | |||
| var issueFullPattern *regexp.Regexp | |||
| var issueFullPattern = regexp.MustCompile(regexp.QuoteMeta(setting.AppURL) + `\w+/\w+/(?:issues|pulls)/((?:\w{1,10}-)?[1-9][0-9]*)([\?|#]\S+.(\S+)?)?\b`) | |||
There was a problem hiding this comment.
setting.AppURL is not guaranteed to be set by the time that you first import modules/markup.
'
This will cause a dependency race that could be very very difficult to fix once it appears.
There was a problem hiding this comment.
aaaa yes how could I have missed that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title - close #16415