-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Just use a slice when rendering file #16774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just use a slice when rendering file #16774
Conversation
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #16774 +/- ##
==========================================
- Coverage 45.52% 45.50% -0.03%
==========================================
Files 762 762
Lines 85939 85937 -2
==========================================
- Hits 39124 39105 -19
- Misses 40508 40520 +12
- Partials 6307 6312 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Make lgtm work |
Highlight currently uses a map which is memory inefficient. Switch to use a slice instead.
Signed-off-by: Andrew Thornton [email protected]