Skip to content

Add Horizontal scrollbar to inner menu on Chrome #17086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Add Horizontal scrollbar to inner menu on Chrome #17086

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebcb9ea
Add Horizontal scrollbar to inner menu on Chrome
zeripath Sep 18, 2021
4bec9c5
Merge branch 'main' into add-scrollbar-to-sub-nav-menu
6543 Sep 20, 2021
a8dd3cf
Merge branch 'main' into add-scrollbar-to-sub-nav-menu
zeripath Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web_src/less/_base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ details summary > * {

::-webkit-scrollbar {
width: 10px;
height: 10px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that all scrollbars are now quadratic because of this.

Or does the scrollbar internally ignore the non-relevant setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you try it?

Copy link
Member

@delvh delvh Sep 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am currently trying it.
Can you please point me somewhere where the horizontal scrollbars should appear?
Because right now I don't see any horizontal scrollbars on the admin pages in Chrome on a minimum width window…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Chromium behave differently than Chrome here?
Because for me, the admin page looks like this:
image

I thought Chrome and Chromium were basically the same thing, with the only difference being that Chromium gets rid of most Google things.

Copy link
Member

@delvh delvh Sep 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see now:
For some reason up until about the half screen, this scrollbar will be displayed.
Only when the screen gets smaller, the tabs will be wrapped.
I would prefer unified behavior:
Either always wrap and never display the scrollbar, or never wrap and always use the scrollbar.
But that is most likely worth its own PR, so for now: lgtm.

My preference is to never use the scrollbar.

}
::-webkit-scrollbar-thumb {
box-shadow: inset 0 0 0 6px var(--color-primary);
Expand Down Expand Up @@ -1285,6 +1286,7 @@ footer {
display: flex;
margin-left: auto;
margin-right: auto;
overflow-x: auto;
}

@media @mediaSm {
Expand Down