Use correct path to snap binary

modules/setting/setting.go

@@ -431,7 +431,14 @@ func IsProd() bool {
 }
 
 func getAppPath() (string, error) {
-	var appPath string
+	appPath := AppPath
+	if giteaAppPath, ok := os.LookupEnv("GITEA_APP_PATH"); ok {
+		appPath = giteaAppPath
+	}
+	if appPath != "" {
+		return appPath, nil
+	}
+
 	var err error
 	if IsWindows && filepath.IsAbs(os.Args[0]) {
 		appPath = filepath.Clean(os.Args[0])
@@ -446,9 +453,24 @@ func getAppPath() (string, error) {
 	if err != nil {
 		return "", err
 	}
+
 	// Note: we don't use path.Dir here because it does not handle case
 	//	which path starts with two "/" in Windows: "//psf/Home/..."
-	return strings.ReplaceAll(appPath, "\\", "/"), err
+	appPath = strings.ReplaceAll(appPath, "\\", "/")
+
+	// Fix issue 16209: When running in a snap and repositories are
+	// created, paths in the hooks include the snap revision. But as new
+	// revisions come out the older revisions are eventually deleted, and
+	// the hooks begin to fail.
+	// The code below replaces the snap revision with "current", which
+	// is a link to the current snap revision.
+	snapPath := os.Getenv("SNAP")
+	if snapPath != "" && strings.HasPrefix(appPath, snapPath) {
+		revision := os.Getenv("SNAP_REVISION")
+		appPath = strings.Replace(appPath, revision, "current", 1)
+	}
+
+	return appPath, nil
 }
 
 func getWorkPath(appPath string) string {

snap/snapcraft.yaml

@@ -45,7 +45,7 @@ parts:
     source: .
     stage-packages: [ git, sqlite3, openssh-client ]
     build-packages: [ git, libpam0g-dev, libsqlite3-dev]
-    build-snaps: [ go, node/14/stable ]
+    build-snaps: [ go, node/16/stable ]
     build-environment:
       - LDFLAGS: ""
     override-pull: |