-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix bug on admin subcommand #17533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix bug on admin subcommand #17533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
reviewed
Nov 3, 2021
zeripath
reviewed
Nov 3, 2021
fa220c8
to
618c587
Compare
@zeripath done. |
Codecov Report
@@ Coverage Diff @@
## main #17533 +/- ##
==========================================
- Coverage 45.49% 45.47% -0.02%
==========================================
Files 793 793
Lines 88811 88843 +32
==========================================
- Hits 40401 40399 -2
- Misses 41897 41928 +31
- Partials 6513 6516 +3
Continue to review full report at Codecov.
|
zeripath
approved these changes
Nov 6, 2021
lafriks
approved these changes
Nov 7, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Fix bug on admin subcommand * Add signals for all initDB Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #17532
PS: looks like it's not different from
InitEngineWithMigration
andInitInstallEngineWithMigration
. I will use only one on another PR.