Skip to content

Fix bug on admin subcommand #17533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 3, 2021

fix #17532

PS: looks like it's not different from InitEngineWithMigration and InitInstallEngineWithMigration. I will use only one on another PR.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 3, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2021
@lafriks lafriks added this to the 1.16.0 milestone Nov 3, 2021
@lunny lunny force-pushed the lunny/fix_db_default_context branch from fa220c8 to 618c587 Compare November 4, 2021 12:00
@lunny
Copy link
Member Author

lunny commented Nov 4, 2021

@zeripath done.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #17533 (493211b) into main (bd613c7) will decrease coverage by 0.01%.
The diff coverage is 15.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17533      +/-   ##
==========================================
- Coverage   45.49%   45.47%   -0.02%     
==========================================
  Files         793      793              
  Lines       88811    88843      +32     
==========================================
- Hits        40401    40399       -2     
- Misses      41897    41928      +31     
- Partials     6513     6516       +3     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/cmd.go 44.18% <0.00%> (ø)
cmd/convert.go 0.00% <0.00%> (ø)
cmd/doctor.go 0.00% <0.00%> (ø)
cmd/dump.go 0.90% <0.00%> (-0.01%) ⬇️
cmd/dump_repo.go 0.00% <0.00%> (ø)
cmd/migrate.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
modules/doctor/doctor.go 12.24% <0.00%> (ø)
routers/install/install.go 0.66% <0.00%> (-0.01%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9110eb...493211b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2021
@lunny lunny merged commit 69b61d4 into go-gitea:main Nov 7, 2021
@lunny lunny deleted the lunny/fix_db_default_context branch November 7, 2021 03:11
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Fix bug on admin subcommand

* Add signals for all initDB

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.16: Runtime panic when creating user
5 participants