Skip to content

Move oauth2 error to oauth2 service package #17603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 10, 2021

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 10, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 10, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17603 (6007e3e) into main (30515f2) will increase coverage by 0.00%.
The diff coverage is 61.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17603   +/-   ##
=======================================
  Coverage   45.48%   45.49%           
=======================================
  Files         793      792    -1     
  Lines       88846    88857   +11     
=======================================
+ Hits        40416    40423    +7     
+ Misses      41918    41917    -1     
- Partials     6512     6517    +5     
Impacted Files Coverage Δ
models/issue_dependency.go 63.76% <0.00%> (ø)
models/lfs_lock.go 57.14% <0.00%> (ø)
models/notification.go 65.28% <0.00%> (-0.88%) ⬇️
models/repo_collaboration.go 57.89% <0.00%> (ø)
modules/doctor/fix16961.go 38.76% <0.00%> (ø)
routers/api/v1/repo/mirror.go 0.00% <0.00%> (ø)
routers/api/v1/repo/transfer.go 60.46% <0.00%> (ø)
routers/init.go 80.80% <0.00%> (ø)
routers/web/admin/auths.go 48.22% <0.00%> (ø)
routers/web/explore/code.go 0.00% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465fb41...6007e3e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2021
@wxiaoguang wxiaoguang merged commit 0e189ee into go-gitea:main Nov 10, 2021
@lunny lunny deleted the lunny/move_oauth2_error branch November 11, 2021 03:19
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants