Skip to content

Use correct Sender on webhook change title #17791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 24, 2021

As title, thanks to @mscherer for pointing out the incorrect code.

As title, thanks to @mscherer for pointing out the incorrect code.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17791 (4f51fc3) into main (7743f13) will increase coverage by 0.03%.
The diff coverage is 52.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17791      +/-   ##
==========================================
+ Coverage   45.54%   45.58%   +0.03%     
==========================================
  Files         807      808       +1     
  Lines       89859    89982     +123     
==========================================
+ Hits        40930    41016      +86     
- Misses      42381    42423      +42     
+ Partials     6548     6543       -5     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/web_https.go 0.00% <ø> (ø)
models/access.go 70.54% <ø> (-0.50%) ⬇️
models/ssh_key_authorized_keys.go 58.82% <ø> (ø)
models/user_email.go 43.41% <0.00%> (-3.65%) ⬇️
routers/api/v1/org/member.go 18.94% <0.00%> (-0.84%) ⬇️
routers/api/v1/repo/star.go 0.00% <0.00%> (ø)
routers/api/v1/user/follower.go 0.00% <0.00%> (ø)
routers/api/v1/user/user.go 52.50% <0.00%> (ø)
routers/private/serv.go 39.57% <0.00%> (-0.86%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d996c8...4f51fc3. Read the comment docs.

@lunny lunny merged commit 21f4401 into go-gitea:main Nov 24, 2021
@lunny
Copy link
Member

lunny commented Nov 24, 2021

Please send backport to v1.15

@Gusted Gusted deleted the fix-webhook-title branch November 24, 2021 08:24
@Gusted
Copy link
Contributor Author

Gusted commented Nov 24, 2021

Please send backport to v1.15

#17792

@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 25, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
As title, thanks to @mscherer for pointing out the incorrect code.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong user on Issue title change for Matrix webhook
7 participants