Skip to content

Test cache during init #17852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2021
Merged

Test cache during init #17852

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbedcf2
Test cache during init
wxiaoguang Nov 29, 2021
60f527a
Show a warning if cache doesn't work correctly.
wxiaoguang Nov 29, 2021
cdab023
Add more comments
wxiaoguang Nov 29, 2021
051b592
Merge branch 'main' into test-cache
wxiaoguang Dec 3, 2021
e0c51c1
Merge branch 'main' into test-cache
lafriks Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions modules/cache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"fmt"
"strconv"

"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/setting"

mc "gitea.com/go-chi/cache"
Expand Down Expand Up @@ -35,6 +36,20 @@ func NewContext() error {
if conn, err = newCache(setting.CacheService.Cache); err != nil {
return err
}
const testKey = "__gitea_cache_test"
const testVal = "test-value"
if err = conn.Put(testKey, testVal, 10); err != nil {
return err
}
val := conn.Get(testKey)
if valStr, ok := val.(string); !ok || valStr != testVal {
// If the cache is full, the Get may not read the expected value stored by Put.
// Since we have checked that Put can success, so we just show a warning here, do not return an error to panic.
log.Warn("cache (adapter:%s, config:%s) doesn't seem to work correctly, set test value '%v' but get '%v'",
setting.CacheService.Cache.Adapter, setting.CacheService.Cache.Conn,
testVal, val,
)
}
}

return err
Expand Down