Skip to content

Remove SizeFmt #17890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2021
Merged

Remove SizeFmt #17890

merged 2 commits into from
Dec 3, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 2, 2021

Removed SizeFmt in favor of FileSize.

@KN4CK3R KN4CK3R added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 2, 2021
@6543 6543 added this to the 1.17.0 milestone Dec 2, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2021
@wxiaoguang wxiaoguang merged commit 6ceef87 into go-gitea:main Dec 3, 2021
@techknowlogick techknowlogick modified the milestones: 1.17.0, 1.16.0 Dec 3, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 3, 2021
@KN4CK3R KN4CK3R deleted the refactor-filesize branch December 16, 2021 13:13
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@KN4CK3R @wxiaoguang
Removed SizeFmt. (go-gitea#17890)
41b7d96 
Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@KN4CK3R @zeripath @wxiaoguang @6543 @techknowlogick @GiteaBot