doc: clarify INSTALL_LOCK behavior #17945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous language was not as clear. I think this conveys the intent, based on reviewing the code. However I note that INSTALL_LOCK also looks used in other places (e.g., `dump.go`) so probably it's impact elsewhere should also be noted here.
This comment has been minimized.
This comment has been minimized.
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Dec 10, 2021
wxiaoguang
approved these changes
Dec 25, 2021
GiteaBot
added
lgtm/need 1
|
I fixed these texts, need another LGTM. |
lunny
approved these changes
Dec 26, 2021
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Dec 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous language was not as clear. I think this conveys the intent, based on reviewing the code. However I note that INSTALL_LOCK also looks used in other places (e.g.,
dump.go) so probably it's impact elsewhere should also be noted here.