Skip to content

Extract CodeMirror styles #17960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2021
Merged

Extract CodeMirror styles #17960

merged 2 commits into from
Dec 20, 2021

Conversation

silverwind
Copy link
Member

  • Extract CodeMirror-related styles to separate files
  • Generalize CodeMirror styles where possible
  • Improve fullscreen and side-by-side mode for dark theme

@silverwind
Extract CodeMirror styles
5001d64 
- Extract CodeMirror-related styles to separate files
- Generalize CodeMirror styles where possible
- Improve fullscreen and side-by-side mode for dark theme
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/bug and removed type/bug labels Dec 11, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2021
@zeripath
Copy link
Contributor

make lgtm

@zeripath zeripath merged commit 3f34f09 into go-gitea:main Dec 20, 2021
@silverwind silverwind deleted the cmtheme branch December 20, 2021 23:45
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@silverwind @6543
Extract CodeMirror styles (go-gitea#17960)
812530c 
- Extract CodeMirror-related styles to separate files
- Generalize CodeMirror styles where possible
- Improve fullscreen and side-by-side mode for dark theme

Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @zeripath @lafriks @GiteaBot @6543