Skip to content

Fix 500 error caused by deleted users on issues (#3675) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Nov 9, 2016
Merged

Fix 500 error caused by deleted users on issues (#3675) #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b59e6f
Fix 500 error caused by deleted users on issues (#3675)
LefsFlare Sep 20, 2016
fd6be0d
Still print error if user does not exist
LefsFlare Nov 4, 2016
a6c487f
Fix err not being nil
LefsFlare Nov 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions models/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ func (issue *Issue) loadAttributes(e Engine) (err error) {
if issue.Poster == nil {
issue.Poster, err = getUserByID(e, issue.PosterID)
if err != nil {
if IsErrUserNotExist(err) {
issue.PosterID = -1
issue.Poster = NewGhostUser()
} else {
issue.PosterID = -1
issue.Poster = NewGhostUser()
if !IsErrUserNotExist(err) {
return fmt.Errorf("getUserByID.(poster) [%d]: %v", issue.PosterID, err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please still print this error if the User infact doesn't exist 🙂

err = nil
return
}
}
Expand Down