Skip to content

Fix various typos #18219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Fix various typos #18219

merged 3 commits into from
Jan 10, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jan 9, 2022

Found via codespell -q 3 -S ./options/locale,./vendor -L ba,pullrequest,pullrequests,readby,te,unknwon

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 9, 2022

Some of these typos are dupes of #18215

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2022
@wxiaoguang
Copy link
Contributor

👍 let's wait for #18215

@@ -6,4 +6,4 @@ Noweb is available free for any use in any field of endeavor. You may redistribu

You may sell noweb if you wish. For example, you may sell a CD-ROM including noweb.

You may sell a derived work, provided that all source code for your derived work is available, at no additional charge, to anyone who buys your derived work in any form. You must give permisson for said source code to be used and modified under the terms of this license. You must state clearly that your work uses or is based on noweb and that noweb is available free of change. You must also request that bug reports on your work be reported to you.
You may sell a derived work, provided that all source code for your derived work is available, at no additional charge, to anyone who buys your derived work in any form. You must give permission for said source code to be used and modified under the terms of this license. You must state clearly that your work uses or is based on noweb and that noweb is available free of change. You must also request that bug reports on your work be reported to you.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo in a LICENSE 😆

Copy link
Member

@silverwind silverwind Jan 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream certainly has the typo too: https://fedoraproject.org/wiki/Licensing:Noweb?rd=Licensing/Noweb, not sure if this is the definitive source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone want to make a patch and submit it upstream, or shall I do it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luzpaz please try to patch it upstream - and revert the change in our copy, as it will be overwritten anyway (by our tool chain)

Copy link
Contributor

@wxiaoguang wxiaoguang Jan 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we might not need to wait for the upstream, and now merge other fixes in this PR first.

Found via `codespell -q 3 -S ./options/locale,./vendor -L ba,pullrequest,pullrequests,readby,te,unknwon`
Revert `modules/git/diff_test.go` revision
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If upstream has new fixes, we can have them in future.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 10, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2022
@lafriks lafriks added type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 10, 2022
@wxiaoguang wxiaoguang merged commit 8c647bf into go-gitea:main Jan 10, 2022
@luzpaz luzpaz deleted the typos branch January 10, 2022 11:34
luzpaz added a commit to luzpaz/gitea that referenced this pull request Jan 10, 2022
@luzpaz luzpaz mentioned this pull request Jan 10, 2022
lunny pushed a commit that referenced this pull request Jan 10, 2022
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 11, 2022
* 'main' of https://github.com/go-gitea/gitea:
  [skip ci] Updated translations via Crowdin
  Fix source typos (go-gitea#18227)
  Fix various typos (go-gitea#18219)
  Remove `ioutil` (go-gitea#18222)
  [skip ci] Updated translations via Crowdin
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Found via `codespell -q 3 -S ./options/locale,./vendor -L ba,pullrequest,pullrequests,readby,te,unknwon`

Co-authored-by: Lunny Xiao <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants