Skip to content

Add vendoring section #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2016
Merged

Add vendoring section #187

merged 2 commits into from
Nov 17, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 16, 2016

Addresses #178

@strk strk mentioned this pull request Nov 16, 2016
Closed
bkcsoft
bkcsoft suggested changes Nov 16, 2016
View reviewed changes
CONTRIBUTING.md
## Vendoring

We keep a cached copy of dependencies under the vendor/ directory,
managing updates via the `govendor` command (github.com/kardianos/govendor)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change to [govendor](https://github.com/kardianos/govendor) instead to be consistent :)

CONTRIBUTING.md
We keep a cached copy of dependencies under the vendor/ directory,
managing updates via the `govendor` command (github.com/kardianos/govendor)

Pull requests should only include vendor/ updates IFF they are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/IFF/IF/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also prefer bold over CAPS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IFF stands for IF and only IF

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, dropped IFF as of 15bd941 (the "only" part is already expressed before)

CONTRIBUTING.md
Pull requests should only include vendor/ updates IFF they are
part of the same change, be it a bugfix or a feature addition.

In any case, the vendor/ change needs to be justified as part
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vendor update needs to be

@bkcsoft bkcsoft added type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Nov 16, 2016
bkcsoft
bkcsoft reviewed Nov 16, 2016
View reviewed changes
CONTRIBUTING.md
Pull requests should only include vendor/ updates if they are
part of the same change, be it a bugfix or a feature addition.

In any case, the vendor/ update needs to be justified as part
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant get rid of In any case,, but that might've been ambiguous 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was. See how you like ac644fd

@codecov-io
Copy link

codecov-io commented Nov 16, 2016 •
edited
Loading

Current coverage is 3.03% (diff: 100%)

Merging #187 into master will not change coverage

@@            master      #187   diff @@
========================================
  Files           33        33          
  Lines         8106      8106          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7840      7840          
  Partials        20        20

Powered by Codecov. Last update d884312...39b3fca

@andreynering
Copy link
Contributor

LGTM

@lunny
Copy link
Member

lunny commented Nov 17, 2016

LGTM. And changes of CONTRIBUTING.md should be agreed with all the three owners. @tboerger

@lunny lunny added this to the 1.0.0 milestone Nov 17, 2016
@strk strk mentioned this pull request Nov 17, 2016
Merged
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Nov 17, 2016
tboerger
tboerger suggested changes Nov 17, 2016
View reviewed changes
Copy link
Member

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I would put the vendor/ into backticks, makes it better visible as a folder name.

CONTRIBUTING.md
@@ -57,6 +57,17 @@ After running for a while, the command should print
```
ALL TESTS PASSED
```
## Vendoring

We keep a cached copy of dependencies under the vendor/ directory,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

within the vendor/

@tboerger
Copy link
Member

You forgot the backticks around the vendor/ mentions

@strk
Copy link
Member Author

strk commented Nov 17, 2016

I can't see any missing backtick in the files changed tab, can you comment there if you do ?

@strk
Copy link
Member Author

strk commented Nov 17, 2016

39b3fca

@tboerger
Copy link
Member

LGTM

@andreynering andreynering merged commit 91953ae into go-gitea:master Nov 17, 2016
@strk strk deleted the vendor branch November 19, 2016 17:03
@moltam
Copy link
Contributor

moltam commented Feb 6, 2017

The Vendoring section was removed in this commit. Was this intentional?

@tboerger
Copy link
Member

The Vendoring section was removed in this commit. Was this intentional?

Not intentional, maybe somebody else got the time to add it back to all our repos?

@lunny
Copy link
Member

lunny commented Feb 10, 2017

fixed by #890, @moltam

ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Jun 3, 2017
Merge pull request go-gitea#187 from ethantkoenig/ufw/vendor
e20e23c 
Remove changes to vendor/ dependencies
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tboerger tboerger tboerger approved these changes

@bkcsoft bkcsoft bkcsoft approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@strk @codecov-io @andreynering @lunny @tboerger @moltam @bkcsoft