Skip to content

migrations: remove dead code in gitea uploader #18725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 21, 2022
Merged

migrations: remove dead code in gitea uploader #18725

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abc9e24
migrations: remove dead code in gitea uploader
singuliere Feb 11, 2022
cc31815
add hint regarding the context in which the method must be called
singuliere Feb 15, 2022
0bc4346
Merge branch 'main' into wip-gitea-uploader
lunny Feb 15, 2022
009a6da
Merge remote-tracking branch 'origin/main' into wip-gitea-uploader
singuliere Feb 19, 2022
75acd8e
Merge remote-tracking branch 'origin/main' into wip-gitea-uploader
singuliere Feb 19, 2022
865246a
Merge branch 'main' into wip-gitea-uploader
lunny Feb 19, 2022
481688a
Merge remote-tracking branch 'origin/main' into wip-gitea-uploader
singuliere Feb 20, 2022
85ae601
Merge remote-tracking branch 'origin/main' into wip-gitea-uploader
singuliere Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions services/migrations/gitea_uploader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,12 +416,7 @@ func (g *GiteaLocalUploader) CreateComments(comments ...*base.Comment) error {
var issue *models.Issue
issue, ok := g.issues[comment.IssueIndex]
if !ok {
var err error
issue, err = models.GetIssueByIndex(g.repo.ID, comment.IssueIndex)
if err != nil {
return err
}
g.issues[comment.IssueIndex] = issue
return fmt.Errorf("comment references non existent IssueIndex %d", comment.IssueIndex)
}

if comment.Created.IsZero() {
Expand Down Expand Up @@ -685,19 +680,14 @@ func convertReviewState(state string) models.ReviewType {
}
}

// CreateReviews create pull request reviews
// CreateReviews create pull request reviews of currently migrated issues
func (g *GiteaLocalUploader) CreateReviews(reviews ...*base.Review) error {
cms := make([]*models.Review, 0, len(reviews))
for _, review := range reviews {
var issue *models.Issue
issue, ok := g.issues[review.IssueIndex]
if !ok {
var err error
issue, err = models.GetIssueByIndex(g.repo.ID, review.IssueIndex)
if err != nil {
return err
}
g.issues[review.IssueIndex] = issue
return fmt.Errorf("review references non existent IssueIndex %d", review.IssueIndex)
}
if review.CreatedAt.IsZero() {
review.CreatedAt = time.Unix(int64(issue.CreatedUnix), 0)
Expand Down