Skip to content

fix #1857 trim Windows line ending #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix #1857 trim Windows line ending #1931

wants to merge 1 commit into from

Conversation

appleboy
Copy link
Member

fix #1857 cc @mrexodia

@appleboy appleboy mentioned this pull request Jun 10, 2017
Closed
7 tasks
@lunny
Copy link
Member

lunny commented Jun 10, 2017

conflict with #1862 ?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2017
@appleboy
Copy link
Member Author

@lunny Yes. we need to choose one of the solutions so maybe @mrexodia can make the decision.

@lunny
Copy link
Member

lunny commented Jun 10, 2017

@appleboy I have tested #1862, that should be OK.

@appleboy
Copy link
Member Author

OK. I closed this issue now.

@appleboy appleboy closed this Jun 10, 2017
@appleboy appleboy deleted the patch-1000 branch June 10, 2017 14:21
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

problems with copying CRLF files in the browser
3 participants
@appleboy @lunny @tboerger